From 9454da3ab330d621f5f5782d3cf0518029ecd515 Mon Sep 17 00:00:00 2001 From: Daniar Mannanov Date: Wed, 26 Aug 2026 02:27:10 +0300 Subject: [PATCH] ci: run the whole verify suite on the self-hosted windows runner MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All three jobs move to [self-hosted, windows]. The race job now adds the machine-wide MSYS2 mingw64 toolchain to GITHUB_PATH: the runner service account only sees the machine PATH, which has no C compiler, so -race could not build its cgo runtime. The dead verify.yml.selfrun file goes away — GitHub never reads that suffix and its content already lives here. --- .github/workflows/verify.yml | 12 +++++++--- .github/workflows/verify.yml.selfrun | 33 ---------------------------- 2 files changed, 9 insertions(+), 36 deletions(-) delete mode 100644 .github/workflows/verify.yml.selfrun diff --git a/.github/workflows/verify.yml b/.github/workflows/verify.yml index 607ee6d..beb5aca 100644 --- a/.github/workflows/verify.yml +++ b/.github/workflows/verify.yml @@ -9,7 +9,7 @@ permissions: jobs: verify: - runs-on: self-hosted + runs-on: [self-hosted, windows] steps: - uses: actions/checkout@v4 - uses: actions/setup-go@v5 @@ -21,19 +21,25 @@ jobs: - run: go test ./... race: - runs-on: ubuntu-latest + runs-on: [self-hosted, windows] + env: + CGO_ENABLED: 1 steps: - uses: actions/checkout@v4 - uses: actions/setup-go@v5 with: go-version: '1.26.x' cache: true + # The runner service account carries only the machine PATH, which has no + # C compiler; point at the machine-wide MSYS2 mingw64 toolchain so the + # race detector can build its cgo runtime. + - run: Add-Content $env:GITHUB_PATH 'C:\msys64\mingw64\bin' # Density-based world tests are intentionally exhaustive and race adds # substantial overhead; keep the package timeout above the normal 10m. - run: go test -race -timeout 20m ./... parity: - runs-on: ubuntu-latest + runs-on: [self-hosted, windows] steps: - uses: actions/checkout@v4 - uses: actions/setup-go@v5 diff --git a/.github/workflows/verify.yml.selfrun b/.github/workflows/verify.yml.selfrun deleted file mode 100644 index 1b8f9f1..0000000 --- a/.github/workflows/verify.yml.selfrun +++ /dev/null @@ -1,33 +0,0 @@ -name: verify - -on: - push: - pull_request: - -permissions: - contents: read - -jobs: - verify: - runs-on: [self-hosted, windows] - steps: - - uses: actions/checkout@v4 - - run: go build ./... - - run: go vet ./... - - run: go test ./... - - race: - runs-on: [self-hosted, windows] - env: - CGO_ENABLED: 1 - steps: - - uses: actions/checkout@v4 - # Density-based world tests are intentionally exhaustive and race adds - # substantial overhead; keep the package timeout above the normal 10m. - - run: go test -race -timeout 20m ./... - - parity: - runs-on: [self-hosted, windows] - steps: - - uses: actions/checkout@v4 - - run: go test ./internal/world -run TestVanillaBlockParity -count=1 -v